Re: [w3c/screen-orientation] Clarify that locking to every orientation might not be supported (PR #217)

@marcoscaceres commented on this pull request.



> @@ -548,7 +548,9 @@ <h2>
       </pre>
       <p>
         The <dfn>OrientationLockType</dfn> enum represents the screen
-        orientations to which a screen can be rotated.
+        orientations to which a screen can be potentially locked to. [=User
+        agents=] are NOT REQUIRED to support locking the screen orientation to
+        any of the values in the {{OrientationLockType}} enum.

Right, yes. Step 3 of lock() was supposed to cover this case:

> If the [user agent](https://infra.spec.whatwg.org/#user-agent) does not support locking the screen orientation due to previously-established user preference, security risk, or platform limitation, return [a promise rejected with](https://webidl.spec.whatwg.org/#a-promise-rejected-with) a "[NotSupportedError](https://webidl.spec.whatwg.org/#notsupportederror)" [DOMException](https://webidl.spec.whatwg.org/#idl-DOMException) and abort these steps.

but making it super explicit is better! I'll move it. 


-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/screen-orientation/pull/217#discussion_r994081931
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/screen-orientation/pull/217/review/1139978102@github.com>