- From: bvandersloot-mozilla <notifications@github.com>
- Date: Wed, 30 Nov 2022 06:08:15 -0800
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/fetch/pull/1533/c1332204094@github.com>
> Given that, should we somewhere assert (and also document under the introduction of the new mode) that the associated [task destination](https://fetch.spec.whatwg.org/#fetch-params-task-destination) for unsafe-no-cors fetches _must be_ a parallel queue? I think so. I'm adding the conditioned assertion into [fetch](https://fetch.spec.whatwg.org/#concept-fetch). RE: the Origin discussion: This is a shortcoming of this PR and I need to add a new member to request to permit forced Origin header elision. Generally speaking, I was operating under the assumption that the client would either be a cloned ESO or null, with the necessary other arguments specified, which is already in the spec as a possible argument. > Do you have a plan for handling the many uses of a request's client with this "new" type of request? Should we audit them all, or take a snapshot of the Document's ESO at some point? I am open to either solution here. I think if there is an expectation that the "client" is a snapshot of some variety, that should be clear and able to be relied upon, so I lean that direction. However, a null client should be applicable here. Looking through the spec there are only a couple of instances where a null client raises my attention and I am curious how they are handled currently: - https://fetch.spec.whatwg.org/#ref-for-concept-request-client%E2%91%A0%E2%91%A4 - https://fetch.spec.whatwg.org/#ref-for-concept-request-client%E2%91%A0%E2%91%A5 - https://fetch.spec.whatwg.org/#ref-for-concept-request-client%E2%91%A1%E2%91%A0 > Also (aside) it seems weird that a request's "window" is pretending to have access to the actual `Window` object when we're not fetching on the Document's main thread) I would expect most uses to have a "window" of "no-window" but do not see a reason to exclude other values. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1533#issuecomment-1332204094 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fetch/pull/1533/c1332204094@github.com>
Received on Wednesday, 30 November 2022 14:08:28 UTC