Re: [w3c/permissions] Define a permission store (closes #384) (PR #390)

@johannhof commented on this pull request.



> +        </dd>
+        <dt>
+          A <dfn data-dfn-for="powerful feature" class="export">permission key comparison algorithm</dfn>:
+        </dt>
+        <dd>
+          <p>
+            Takes two [=permission keys=] and returns a boolean that shows whether the two keys are equal.
+            If unspecified, this defaults to the <a>default permission key comparison algorithm</a>.
+          </p>
+          <p>
+            The <dfn class="export">default permission key comparison algorithm</dfn>,
+            given [=permission keys=] |key1| and |key2|, runs the following steps:
+          </p>
+          <ol class="algorithm">
+            <li>
+              If |key1| is not an [=origin=] or |key2| is not an [=origin=] return false.

I mean, yeah, the spec should use these in the right way, so it's not 100% clear to me whether we really need this safeguard. I'll at least move it out of the feature-defined algo to be a more generic check based on the permission key type.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/permissions/pull/390#discussion_r1035962428
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/permissions/pull/390/review/1199315968@github.com>