- From: Johann Hofmann <notifications@github.com>
- Date: Wed, 30 Nov 2022 05:10:00 -0800
- To: w3c/permissions <permissions@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 30 November 2022 13:10:13 UTC
@johannhof commented on this pull request. > @@ -278,6 +278,71 @@ <h3> reset because its [=permission/lifetime=] has expired. </p> </section> + <section> + <h3> + Permission Store + </h3> + <p> + The user agent maintains a single <dfn class="export">permission store</dfn> which is a [=/list=] of [=permission store entries=]. Hmm having tried this now I realize that using a map is a major change to the concepts we've been proposing in this PR as of now. It's a departure from saying e.g. "get a permission store entry" to something like "get the permission state for a permission store key", where the key would now be (description, key) and we might have to rename the latter key to something like "scope". Overall I'm not a fan of that new map approach personally, and wanted to get thoughts on this change before writing it all up :) Would you be comfortable with just using a set as an alternative to ensure this invariant? (cc @annevk) -- Reply to this email directly or view it on GitHub: https://github.com/w3c/permissions/pull/390#discussion_r1035949702 You are receiving this because you are subscribed to this thread. Message ID: <w3c/permissions/pull/390/review/1199297363@github.com>
Received on Wednesday, 30 November 2022 13:10:13 UTC