Re: [whatwg/fullscreen] Hide pop-ups when making an element fullscreen (PR #204)

@foolip commented on this pull request.



> @@ -65,8 +65,15 @@ stated otherwise it is unset.
 <p>All <a for=/>documents</a> have an associated <dfn>list of pending fullscreen events</dfn>, which
 is an <a>ordered set</a> of (<a>string</a>, <a>element</a>) <a>tuples</a>. It is initially empty.
 
-<p>To <dfn>fullscreen an <var>element</var></dfn>, set <var>element</var>'s <a>fullscreen flag</a>
-and <a for="top layer">add</a> it to its <a>node document</a>'s <a>top layer</a>.
+<p>To <dfn>fullscreen an <var>element</var></dfn>:
+
+<ol>
+ <li><p>Run {hide all pop-ups until} given null, false, and false.

It would be more obvious what this does if HTML defines a "hide all popovers" method that takes a document argument. It would be used both here and by `<dialog>`. Right now, you have to find "If endpoint is null" is the algorithm to understand this ensures there are no popovers left in the top layer after this.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/pull/204#pullrequestreview-1193349359
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fullscreen/pull/204/review/1193349359@github.com>