- From: Anne van Kesteren <notifications@github.com>
- Date: Wed, 23 Nov 2022 06:58:10 -0800
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 23 November 2022 14:58:23 UTC
@annevk commented on this pull request. > @@ -6455,8 +6495,13 @@ method steps are to <a for=Headers>append</a> (<var>name</var>, <var>value</var> <li><p>If <a>this</a>'s <a for=Headers>guard</a> is "<code>immutable</code>", then <a>throw</a> a {{TypeError}}. - <li><p>Otherwise, if <a>this</a>'s <a for=Headers>guard</a> is "<code>request</code>" and - <var>name</var> is a <a>forbidden header name</a>, return. + <li> + <p>Otherwise, if <a>this</a>'s <a for=Headers>guard</a> is "<code>request</code>" and + (<var>name</var>, ``) is a <a>forbidden request-header</a>, return. + + <p class=note>Passing a dummy <a>header value</a> to <a>forbidden request-header</a> ought not to + have any negative repercussions. + <!-- XXX Under what circumstances can this return statement be reached? --> I was forgetting that a specification might set a `Sec-` header. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1541#discussion_r1030546966 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fetch/pull/1541/review/1191802362@github.com>
Received on Wednesday, 23 November 2022 14:58:23 UTC