- From: Domenic Denicola <notifications@github.com>
- Date: Wed, 23 Nov 2022 04:43:26 -0800
- To: whatwg/storage <storage@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 23 November 2022 12:43:38 UTC
@domenic commented on this pull request. Looking promising! > @@ -20,4 +20,6 @@ local: storage.bs deploy: storage.bs curl --remote-name --fail https://resources.whatwg.org/build/deploy.sh + POST_BUILD_STEP='npm run build-diagram' ```suggestion POST_BUILD_STEP='npm run build-diagram' \ ``` > @@ -0,0 +1,12 @@ +erDiagram Hmm, now this lives in scripts/, which is a bit weird... maybe it should live in top-level? -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/storage/pull/152#pullrequestreview-1191576465 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/storage/pull/152/review/1191576465@github.com>
Received on Wednesday, 23 November 2022 12:43:38 UTC