Re: [whatwg/storage] Editorial: Add a diagram for storage model (PR #152)

@annevk commented on this pull request.

It's unfortunate that preview doesn't work for these images. I guess that's due to it only doing a Bikeshed build and not a full build.

@domenic can you do a quick peak? I'd love your thoughts on:

1. Doing models.
2. The Node.js stuff here.
3. Using `assets/` for structure.

(Mainly because if this is good, we should adopt it elsewhere, e.g., in Fetch.)

> @@ -1,3 +1,5 @@
 /storage.spec.whatwg.org/
 /deploy.sh
 /storage.html
+/node_modules/
+package-lock.json

This we'll also have to change upstream: https://github.com/whatwg/spec-factory/blob/main/factory.json. But it's straightforward enough.

> +<figure>
+  <img src=assets/model-diagram.svg alt="Storage model diagram" aria-describedby=model-description
+width=396 height=815>
+  <figcaption>A storage model diagram, described below.</figcaption>
+</figure>

This is what I had in mind:
```suggestion
<p><img src=assets/model-diagram.svg alt="Storage model diagram (described in the next paragraph)."
width=396 height=815>
```
I think what's currently proposed is rather unwieldy and would also result in a lot of duplication of content for AT users.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/storage/pull/152#pullrequestreview-1190425443
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/storage/pull/152/review/1190425443@github.com>