Re: [w3c/clipboard-apis] Add Web Custom format (PR #175)

Hello @snianu ,

I've tried to review the current state after I have seen your presentation at the TPAC.

Here are my rather nitty gritty comments:

- sec 7.2 (ClipboardItem Interface): should `is custom` really be written in two words and not in one? The link in the version I could build did not work but that might be a local issue.
- the spreadsheet example close to that is nice, could it not also include a custom type? (e.g. containing  text/csv alternative?)
- A web custom format has is custom set to true. => A representation in a web custom format has is custom set to true ?
- 7.3.3: write algorithm: f type is not in the mandatory data types list and has "web ":   did you not mean “or has...” ?
- write blobs and option to the clipboard:
   - step 1: why is the variable called webCustomFormat ? It should be formats or something universal, right?
   - substeps under 2.2: "If formatString is empty then follow the below steps:": the steps here does not define a (non-empty) formatString; a value is however needed in order for the recipients to read (suggestion: “set formatString to  a randomly chosen format name”)
  - step 2.3: Let payload be the result of UTF-8 decoding item’s underlying byte sequence. : this must be a misunderstanding as it would only apply to text. Maybe the whole section was about text? Then it was not readable
- the steps of “write web custom formats” sound quite solid to me but why is it independent from the previous?

Tell me if I should make my comments more precise (e.g. with line numbers).

I am quite excited by the implementation found in Chromium (and [blogged about it](https://mathmlmuses.netlify.app/trymathml-copy-customtypes/)). I suspect that we are getting close to acceptance, at least provided that Mozilla will consider implementing as it seems it said at the start.

thanks and sorry to be slow to have reviewed.

Paul


-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/clipboard-apis/pull/175#issuecomment-1315858767

You are receiving this because you are subscribed to this thread.

Message ID: <w3c/clipboard-apis/pull/175/c1315858767@github.com>