Re: [whatwg/fullscreen] Hide pop-ups when making an element fullscreen (PR #204)

@annevk commented on this pull request.



> @@ -234,6 +241,8 @@ if all of the following are true, and false otherwise:
  <li><p><var>element</var>'s <a>node document</a> is <a>allowed to use</a> the "<code><a
  data-lt="fullscreen-feature">fullscreen</a></code>" feature.
  <!-- cross-process, recursive -->
+
+ <li><p><var>element</var> is not in the {{popover showing state}}.

Presumably:
```suggestion
 <li><p><var>element</var> is not in the [=popover showing state=].
```

> + <li><p>Set <var>element</var>'s <a>fullscreen flag</a>
+
+ <li><p><a for="top layer">add</a> it to its <a>node document</a>'s <a>top layer</a>.

```suggestion
 <li><p>Set <var>element</var>'s <a>fullscreen flag</a>.

 <li><p><a for="top layer">Add</a> <var>element</var> to <var>element</var>'s <a>node document</a>'s
 <a>top layer</a>.
```

> @@ -65,8 +65,15 @@ stated otherwise it is unset.
 <p>All <a for=/>documents</a> have an associated <dfn>list of pending fullscreen events</dfn>, which
 is an <a>ordered set</a> of (<a>string</a>, <a>element</a>) <a>tuples</a>. It is initially empty.
 
-<p>To <dfn>fullscreen an <var>element</var></dfn>, set <var>element</var>'s <a>fullscreen flag</a>
-and <a for="top layer">add</a> it to its <a>node document</a>'s <a>top layer</a>.
+<p>To <dfn>fullscreen an <var>element</var></dfn>:
+
+<ol>
+ <li><p>Run {hide all pop-ups until} given null, false, and true.

This should say popover now.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/pull/204#pullrequestreview-1178719697
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fullscreen/pull/204/review/1178719697@github.com>