Re: [whatwg/fetch] Add the Priority Hints changes to the fetch spec (PR #1523)

@annevk commented on this pull request.

Thank you for working on this!

I'm not seeing the outcome of https://github.com/WICG/priority-hints/issues/69 incorporated here.

We might also want to say a bit more about "internal priority".

Please also draft a commit message (as a comment) that links the appropriate HTML changes and makes it clear that all of this essentially obsoletes the Priority Hints specification. (I'm assuming that's the intent given there's no normative references.)

> @@ -1733,7 +1733,12 @@ not always relevant and might require different behavior.
 <hr>
 
 <p>A <a for=/>request</a> has an associated
-<dfn export for=request id=concept-request-priority>priority</dfn> (null or a
+<dfn export id=concept-request-priority>priority</dfn>, which is
+"<code>high</code>", "<code>low</code>" or "<code>auto</code>". Unless stated otherwise it is
+"<code>auto</code>".
+
+<p>A <a for=/>request</a> has an associated
+<dfn export for=request id=concept-request-internal-priority>internal priority</dfn> (null or a
 user-agent-defined object). Unless otherwise stated it is null.

Can we make this `an <a>implementation-defined</a> object` while here? (Also applies below.)

> @@ -7070,6 +7081,10 @@ object), initially null.
  <span class=note>See <a href="https://github.com/whatwg/fetch/issues/1254">issue #1254</a> for
  defining "<code>full</code>".</span>
 
+<dt><code><var>request</var> . <a attribute for=Request>priority</a></code>

Indentation is wrong.

> @@ -7070,6 +7081,10 @@ object), initially null.
  <span class=note>See <a href="https://github.com/whatwg/fetch/issues/1254">issue #1254</a> for
  defining "<code>full</code>".</span>
 
+<dt><code><var>request</var> . <a attribute for=Request>priority</a></code>
+ <dd>Returns the <a>priority</a> of the <var>request</var>, e.g., "<code>high</code>",
+ "<code>low</code>" or "<code>auto</code>".

Oxford comma.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1523#pullrequestreview-1173785508
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1523/review/1173785508@github.com>