Re: [whatwg/dom] Add pop-up light dismiss logic to event dispatching (PR #1117)

@josepharhar commented on this pull request.



> +     <li><p>Run {light dismiss open pop-ups} given <var>struct</var>'s <a
+     for=Event/path>invocation target</a>.

There has been some discussion about the constraints of when to actually light dismiss based on the event here, hopefully the new changes address this concern: https://github.com/whatwg/html/issues/7785#issuecomment-1299086185

> It seems to me that the implementation only does something for mouse and keyboard input.

Do you mean that it should only work if the event is trusted? The implementation does not currently check isTrusted, and [mason's new patch](https://chromium-review.googlesource.com/c/chromium/src/+/3995612/1/third_party/blink/renderer/core/html/html_element.cc#1744) doesn't do so either.

> Although maybe also for synthetic mouse and keyboard input? It still strikes me as somewhat wrong to have it as part of event dispatch. What's the design motivation for that?

I don't know what the design motivation was, but if you have any alternative ideas I'm all ears

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1117#discussion_r1011048818
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/1117/review/1164257881@github.com>