Re: [whatwg/fetch] Call `finalize and report timing` automatically on end-of-body (PR #1413)

@yutakahirano commented on this pull request.



> @@ -3867,6 +3892,10 @@ the request.
       wanting to do a ping without request body might do so as well, but if you do have a request
       body you definitely need this as otherwise transmit-request-body loop breaks down. -->
 
+ <li><p>If <var>timingGlobal</var> is "<code>client</code>", then set <var>timingGlobal</var> to

What happens if request's client is null? Should we move this to the "if request's client is non-null" block above?

>     <li><p>Set <var>fetchParams</var>'s <a for="fetch params">request</a>'s
    <a for=request>done flag</a>.
 
+   <li>
+    <p>If <var>fetchParams</var>'s <a for="fetch params">request</a>'s
+    <a for=request>destination</a> is "<code>document</code>", then set <var>fetchParams</var>'s
+    <a for="fetch params">controller</a>'s <a for="fetch controller">full timing info</a> to
+    <var>fetchParams</var>'s <a for="fetch params">timing info</a>.
+
+    <p>Set <var>fetchParams</var>'s <a for="fetch params">controller</a>'s <a

https://github.com/whatwg/fetch#formatting

"Using newlines between "inline" element tag names and their content is also forbidden. (This actually alters the content, by adding spaces.)"

>     <li><p>Set <var>fetchParams</var>'s <a for="fetch params">request</a>'s
    <a for=request>done flag</a>.
 
+   <li>
+    <p>If <var>fetchParams</var>'s <a for="fetch params">request</a>'s
+    <a for=request>destination</a> is "<code>document</code>", then set <var>fetchParams</var>'s
+    <a for="fetch params">controller</a>'s <a for="fetch controller">full timing info</a> to
+    <var>fetchParams</var>'s <a for="fetch params">timing info</a>.
+
+    <p>Set <var>fetchParams</var>'s <a for="fetch params">controller</a>'s <a
+    for="fetch controller">report timing steps</a> to the following steps given a <a
+    for=/>global object</a> <var>global</var>:
+
+    <ol>
+     <li><p>If <var>fetchParams</var>'s <a for="fetch params">request</a>'s <a for=request>URL</a>'s

Do we want to use the scheme name ("https" vs. "http")? Or should we check if the URL is trustworthy?


-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1413#pullrequestreview-987538962
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1413/review/987538962@github.com>