- From: Yutaka Hirano <notifications@github.com>
- Date: Wed, 25 May 2022 03:44:32 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/fetch/pull/1413/review/984597514@github.com>
@yutakahirano commented on this pull request. I prefer this version much more to the one I looked at first. > <li><p>Set <var>fetchParams</var>'s <a for="fetch params">request</a>'s <a for=request>done flag</a>. + <li><p>Let <var>global</var> be <var>fetchParams</var>'s <a for="fetch params">timing global</a>. + + <li> + <p>If <var>global</var> is not null, then <a>queue a fetch task</a> given + <var>fetchParams</var>'s <a for="fetch params">timing global</a> to run the following steps: Just `<var>global</var>` should be fine. > @@ -8267,6 +8235,16 @@ in a <a for=/>parallel queue</a> if <a for=fetch><i>useParallelQueue</i></a> is <dt><a for=fetch><i>useParallelQueue</i></a> <dd><p>Takes a <a for=/>boolean</a> that defaults to false. Indicates where the algorithms passed as arguments will be invoked. Hopefully most standards will not need this. + + <dt><a for=fetch><i>initiatorType</i></a> + <dd><p>Takes a string that defaults to "<code>other</code>", to indicate the + {{PerformanceResourceTiming/initiatorType}} for <cite>Resource Timing</cite>. [[RESOURCE-TIMING]] + + <dt><a for=fetch><i>timingGlobal</i></a> + <dd><p>Takes "<code>client</code>", "<code>none</code>" or a <a for=/>global object</a> (default Should `"<code>none</node>"` be `null`? I see in some text in this change comapres `timingGlobal` with `null`. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1413#pullrequestreview-984597514 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fetch/pull/1413/review/984597514@github.com>
Received on Wednesday, 25 May 2022 10:44:44 UTC