Re: [whatwg/streams] add TrasformStream finally callback (PR #1231)

@MattiasBuelens commented on this pull request.



>   1. Perform ! [$TransformStreamDefaultControllerClearAlgorithms$](|stream|.[=TransformStream/[[controller]]=]).
  1. Perform !
     [$WritableStreamDefaultControllerErrorIfNeeded$](|stream|.[=TransformStream/[[writable]]=].[=WritableStream/[[controller]]=], |e|).
  1. If |stream|.[=TransformStream/[[backpressure]]=] is true, perform ! [$TransformStreamSetBackpressure$](|stream|,
     false).
+ 1. Perform ! |stream|.[=TransformStream/[[controller]]=].[=TransformStreamDefaultController/[[finallyAlgorithm]]=]().

This algorithm will already have been cleared by `TransformStreamDefaultControllerClearAlgorithms` in step 1, so this won't work.

> @@ -5965,6 +5981,7 @@ side=] of [=transform streams=].
  1. Perform ! [$TransformStreamDefaultControllerClearAlgorithms$](|controller|).
  1. Return the result of [=reacting=] to |flushPromise|:
   1. If |flushPromise| was fulfilled, then:
+   1. Perform ! |stream|.[=TransformStream/[[controller]]=].[=TransformStreamDefaultController/[[finallyAlgorithm]]=]().

Once again, this algorithm has already been cleared in step 4.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/1231#pullrequestreview-982413536
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/streams/pull/1231/review/982413536@github.com>