Re: [w3c/clipboard-apis] Remove sanitize copy requirement from the spec. (PR #174)

@BoCupp-Microsoft commented on this pull request.



> @@ -837,11 +837,11 @@ urlPrefix: https://w3c.github.io/FileAPI/#dfn-; type: dfn;
 
      1. Abort these steps.
 
-    1. Let |data| be a copy of the [=system clipboard data=] represented as [=clipboard items=]. For the MIME types defined in the [=mandatory data types=] list, |data| contains the sanitized copy of text/plain format.
+    1. Let |data| be a copy of the [=system clipboard data=] represented as [=clipboard items=]. For the MIME types defined in the [=mandatory data types=] list, |data| contains the content of text/plain format.

Suggest that we change:

>For the MIME types defined in the [=mandatory data types=] list, |data| contains the content of text/plain format.

to 

For the MIME types defined in the [=mandatory data types=] list, |data| MAY be sanitized.


>  
      Issue: Some OSs contain multiple clipboard (e.g. Linux, "primary", "secondary", "selection"). Define from which of those data is read.
 
-     Issue: Add definition of sanitized copy.
+     Issue: Currently Safari does some sanitization. See https://github.com/w3c/clipboard-apis/issues/150.

Not sure if we need this issue if we have agreement on saying data MAY be sanitized above.

> @@ -953,17 +953,9 @@ urlPrefix: https://w3c.github.io/FileAPI/#dfn-; type: dfn;
 
        1. If |type| is not in the [=mandatory data types=] list, then [=reject=] |p| with {{"NotAllowedError"}} {{DOMException}} in |realm| and abort these steps.
 
-       1. Let |cleanItem| be a sanitized copy of |blob|.

Maybe instead change to be:

1. Let |cleanItem| be an optionally sanitized copy of |blob|

> @@ -953,17 +953,9 @@ urlPrefix: https://w3c.github.io/FileAPI/#dfn-; type: dfn;
 
        1. If |type| is not in the [=mandatory data types=] list, then [=reject=] |p| with {{"NotAllowedError"}} {{DOMException}} in |realm| and abort these steps.
 
-       1. Let |cleanItem| be a sanitized copy of |blob|.
-
-        Issue: Add definition of sanitized copy.
-
-       1. If unable to create a sanitized copy, then follow the below steps:

Maybe change to be:

1. If sanitization was attempted and was not successfully completed, then follow the below steps:

> @@ -1702,19 +1694,9 @@ urlPrefix: https://w3c.github.io/FileAPI/#dfn-; type: dfn;
 
   1. Else
 
-   1. This is left to the implementation...
-
-    Issue: It's not good to leave things up to the
-    implementation. What should happen here?
+   1. Assign "" to |wellKnownFormat|.

This seems like it could be a separate PR as it isn't directly related to allowing an optional sanitization of the well-known formats?

> @@ -786,15 +786,15 @@ urlPrefix: https://w3c.github.io/FileAPI/#dfn-; type: dfn;
 
      1. Abort these steps.
 
-    1. Let |data| be a copy of the [=system clipboard data=] represented as [=clipboard items=]. For the MIME types defined in the [=mandatory data types=] list, |data| contains the sanitized copy of text/html format, but image/png format has unsanitized payload to preserve meta data.
+    1. Let |data| be a copy of the [=system clipboard data=] represented as [=clipboard items=]. For the MIME types defined in the [=mandatory data types=] list, |data| contains the content of text/html format, but image/png format has unsanitized payload to preserve meta data.

Suggest that we change the sentence starting with:

> For the MIME types defined...

to 

For the MIME types defined in the [=mandatory data types=] list, |data| MAY be sanitized

>  
      Issue: Some OSs contain multiple clipboard (e.g. Linux, "primary", "secondary", "selection"). Define from which of those data is read.
 
+     Issue: Currently Safari does some sanitization for [=mandatory data types=]. See https://github.com/w3c/clipboard-apis/issues/150.

Same as I mentioned below... not sure if we need this called out if we are using language that makes it clear sanitization is optional.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/clipboard-apis/pull/174#pullrequestreview-979102283
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/clipboard-apis/pull/174/review/979102283@github.com>