Re: [whatwg/fetch] Add a render-blocking boolean flag to the request concept (PR #1432)

@annevk commented on this pull request.

Thanks, this looks good to me modulo some nits.

> @@ -1869,6 +1869,12 @@ otherwise, it is unset.
 <a for=request>done flag</a>, and <a for=request>timing allow failed flag</a> are used as
 bookkeeping details by the <a for=/>fetch</a> algorithm.
 
+<p>A <a for=/>request</a> has an associated boolean
+<dfn export for=request id=concept-request-render-blocking>render-blocking</dfn>.

Please remove the ID attribute here. It's not needed for new definitions.

> @@ -3984,8 +3990,9 @@ the request.
 
  <li>
   <p>If <var>request</var>'s <a for=request>priority</a> is null, then use <var>request</var>'s
-  <a for=request>initiator</a> and <a for=request>destination</a> appropriately in setting
-  <var>request</var>'s <a for=request>priority</a> to a user-agent-defined object.
+  <a for=request>initiator</a>, <a for=request>destination</a> and

```suggestion
  <a for=request>initiator</a>, <a for=request>destination</a>, and
```

> +<p>A <a for=/>request</a> has an associated boolean
+<dfn export for=request id=concept-request-render-blocking>render-blocking</dfn>.
+Unless stated otherwise, it is false.
+
+<p class=note>This flag is for exclusive use by HTML's render-blocking mechanism. [[!HTML]]

Let move this up to be before the `<hr>` above so the request bookkeeping details stay last.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1432#pullrequestreview-976465281
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1432/review/976465281@github.com>

Received on Wednesday, 18 May 2022 07:21:08 UTC