- From: Anne van Kesteren <notifications@github.com>
- Date: Tue, 17 May 2022 05:56:54 -0700
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 17 May 2022 12:57:07 UTC
@annevk commented on this pull request. Thanks, this looks good to me, modulo a small oversight. Anyone else that should review this? @mfreed7 perhaps? > @@ -5135,8 +5171,7 @@ method steps are to return the <a>list of elements with class names <var>classNa <a for=/>node</a> whose <a for=ProcessingInstruction>target</a> is <var>target</var> and <a for=CharacterData>data</a> is <var>data</var>. - If <var>target</var> does not match the - <code><a type>Name</a></code> production an + If <var>target</var> is not a <a>valid basic name</a> an This changes the validation for `ProcessingInstruction` in a domintro box. That seems like an oversight. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/1079#pullrequestreview-975413867 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/dom/pull/1079/review/975413867@github.com>
Received on Tuesday, 17 May 2022 12:57:07 UTC