- From: Lea Verou <notifications@github.com>
- Date: Wed, 11 May 2022 11:01:50 -0700
- To: w3ctag/design-reviews <design-reviews@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 11 May 2022 18:02:02 UTC
Hi there,
Thanks for the detailed explainer and for working on solving this very common problem!
Some thoughts and questions as I look through this (just from me, we haven't discussed this in a call yet):
- I see that toggle triggers become focusable. How does that interact with other ways to control focusability?
- `toggle-visibility` seems like a pretty thin abstraction to be worth the extra API surface. Isn't it possible to do with the rest of the syntax with only a couple lines of code?
> Avoiding recursive behavior with toggle selectors
Not sure if I misunderstood something, can't you create a cycle like this:
```css
div:toggle(foo 1) {
toggle-root: foo 2 at 2;
}
div:toggle(foo 2) {
toggle-root: foo 2 at 1;
}
```
- I found it pretty hard to understand some of the more advanced examples, e.g. `toggle-root: slides 4 at 1 sticky`, `toggle-trigger: page set saving;`, possibly because syntax and values (`at`, `set` keywords and author-defined identifiers) are mixed and on the same level.
--
Reply to this email directly or view it on GitHub:
https://github.com/w3ctag/design-reviews/issues/730#issuecomment-1124101601
You are receiving this because you are subscribed to this thread.
Message ID: <w3ctag/design-reviews/issues/730/1124101601@github.com>
Received on Wednesday, 11 May 2022 18:02:02 UTC