- From: Anne van Kesteren <notifications@github.com>
- Date: Tue, 10 May 2022 01:25:19 -0700
- To: whatwg/dom <dom@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 10 May 2022 08:25:30 UTC
@annevk commented on this pull request. Do we want to call out the `=` difference in a note? At least a comment would be good I think. I'm not a big fan of adding "DOM API" to the naming. That makes more sense if this was defined outside of the DOM Standard itself. I think dropping it would still make everything work. > + <li>If <var>target</var> is does not match the <!--<code data-anolis-type>PITarget</code>--> - <code><a type>Name</a></code> production, + <code>[=XML/Name=]</code> production, then <a>throw</a> an "{{InvalidCharacterError!!exception}}" {{DOMException}}. <!-- DOM3 does not check for "xml" --> The added "is" here seems incorrect. Might also want to drop the dated comments while here. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/dom/pull/1079#pullrequestreview-967366976 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/dom/pull/1079/review/967366976@github.com>
Received on Tuesday, 10 May 2022 08:25:30 UTC