- From: Marcos Cáceres <notifications@github.com>
- Date: Mon, 09 May 2022 01:33:47 -0700
- To: w3c/permissions <permissions@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <w3c/permissions/pull/376/review/965762004@github.com>
@marcoscaceres commented on this pull request.
> @@ -652,26 +652,26 @@ <h3>
</h3>
<p>
To <dfn data-lt="prompt the user to choose|prompting the user to choose" class=
- "export">prompt the user to choose</dfn> one of several |options| associated with a
- |descriptor|, the user agent must perform the following steps. This algorithm returns
- either {{PermissionState/"denied"}} or one of the options.
+ "export">prompt the user to choose</dfn> one or more of several |options| associated with
+ a |descriptor|, the user agent must perform the following steps. This algorithm returns
```suggestion
a |descriptor|, and optionally a [=non-negative integer=] greater than 1 |restrictions|, which restricts how many |options| a user can select, the user agent must perform the following steps. This algorithm returns
```
> @@ -652,26 +652,26 @@ <h3>
</h3>
<p>
To <dfn data-lt="prompt the user to choose|prompting the user to choose" class=
- "export">prompt the user to choose</dfn> one of several |options| associated with a
- |descriptor|, the user agent must perform the following steps. This algorithm returns
- either {{PermissionState/"denied"}} or one of the options.
+ "export">prompt the user to choose</dfn> one or more of several |options| associated with
+ a |descriptor|, the user agent must perform the following steps. This algorithm returns
+ either {{PermissionState/"denied"}} or the selected option(s).
</p>
<ol class="algorithm">
<li>If |descriptor|'s <a>permission state</a> is {{PermissionState/"denied"}}, return
Then we probably want:
```suggestion
<li>Assert: If |restrictions| was passed, |restrictions| is less than or equal to the [=list/size=] of |options|.</li>
<li>If |descriptor|'s <a>permission state</a> is {{PermissionState/"denied"}}, return
```
> @@ -652,26 +652,26 @@ <h3>
</h3>
<p>
To <dfn data-lt="prompt the user to choose|prompting the user to choose" class=
- "export">prompt the user to choose</dfn> one of several |options| associated with a
- |descriptor|, the user agent must perform the following steps. This algorithm returns
- either {{PermissionState/"denied"}} or one of the options.
+ "export">prompt the user to choose</dfn> one or more of several |options| associated with
```suggestion
"export">prompt the user to choose</dfn> one or more of several [=list/items=] from a [=list=] of |options| associated with
```
> </li>
- <li>Ask the user to choose one of the options or deny permission, and wait for them to
- choose. If the calling algorithm specified extra information to include in the prompt,
- include it.
+ <li>Ask the user to choose one or more of the options or deny permission, and wait for
Then something like:
```suggestion
<li>Ask the user to choose one or more of the options or deny permission. If |restrictions| was passed, then restrict how many |options| to that number. Wait for
```
--
Reply to this email directly or view it on GitHub:
https://github.com/w3c/permissions/pull/376#pullrequestreview-965762004
You are receiving this because you are subscribed to this thread.
Message ID: <w3c/permissions/pull/376/review/965762004@github.com>
Received on Monday, 9 May 2022 08:33:59 UTC