Re: [whatwg/webidl] WIP: switching maplike/setlike to use infra maps and sets (PR #1138)

@tabatkins commented on this pull request.



>          1.  Let |valueArg| be the second argument passed to this function, or <emu-val>undefined</emu-val> if not supplied.
-        1.  Let |keyIDL| be the result of [=converted to an IDL value|converting=] |keyArg| to an IDL value of type |keyType|.
-        1.  Let |valueIDL| be the result of [=converted to an IDL value|converting=] |valueArg| to an IDL value of type |valueType|.
-        1.  Let |key| be the result of [=converted to ECMAScript values|converting=] |keyIDL| to an ECMAScript value.
-        1.  Let |value| be the result of [=converted to ECMAScript values|converting=] |valueIDL| to an ECMAScript value.
-        1.  Perform [=?=] <a abstract-op>Call</a>(|function|, |map|, «|key|, |value|»).
-        1.  Return |O|.
+        1.  Let |value| be |valueArg| [=converted to an IDL value=] of type |valueType|.
+        1.  [=map/Set=] |map|[|key|] to |value|.
+        1.  Return |value| [=converted to an ECMAScript value=].

Whoops, indeed, not sure why I thought it returned the value. I know I wrote that on purpose, huh.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/webidl/pull/1138#discussion_r864306440

You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/webidl/pull/1138/review/961153676@github.com>

Received on Tuesday, 3 May 2022 22:29:19 UTC