Re: [whatwg/fetch] Specify connection timing for HTTP/3 (PR #1417)

@ianswett commented on this pull request.

I'm new to this text, but some comments.

I believe the text that references TLS could probably be more specific, but I'd prefer to defer that to someone else.

> @@ -2643,7 +2647,10 @@ boolean <var>http3Only</var>, run these steps:
  <li><p>If a secure transport is used, <var>timingInfo</var>'s

The above paragraphs already talk about secure connections implicitly, so maybe some of this should be moved up?

For HTTP/3, I'm not sure you need to add anything, though if you wanted to say "If a secure transport is used, such as TLS over TCP or QUIC, ..." that could clarify that you're including both.

> @@ -2630,6 +2630,10 @@ boolean <var>http3Only</var>, run these steps:
    <li><p>If the user agent waits for full handshake completion to send the request, this interval
    includes the full TLS handshake even if other requests were sent using early data on
    <var>connection</var>.
+
+   <li><p>If the connection is an HTTP/3 <a>connection</a>,
+   <var>timingInfo</var>'s <a for="connection timing info">connection end time</a> should represent
+   the time right after the TLS handshake. [[!HTTP3]]

I think HTTP/3 is pretty much the same as other versions of HTTP over TLS 1.3 in that if you send early data, you don't wait for the ServerHello?  If you want to use a term from the RFC for when all requests can be sent, I'd use 'Handshake Complete', which is the point at which the client has the final 1-RTT keys.

I'll note that early data can be rejected, and it might be worth clarifying whether the time the early data is initially sent should be used or after rejection.  I suspect the former, but it's worth being clear I think.

Note: 'handshare' is misspelled on line 2626.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1417#pullrequestreview-919122292
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1417/review/919122292@github.com>