Re: [whatwg/fetch] Allow timing reporting with origin (for iframes) (PR #1388)

@annevk commented on this pull request.

So you can end up with that scenario when the cross-origin isolated capability is not delegated through Permissions Policy. Is the problem here that we use the capability of the parent and not the child? It seems that's what we should address somehow, right?

> + <li>Set <var>response</var>'s <a for="response">timing info</a> to the
+ result of calling <a>report timing</a> given <var>response</var>, <var>global</var>,
+ <var>initiatorType</var>, and <var>taoPass</var>.

```suggestion
 <li><p>Set <var>response</var>'s <a for="response">timing info</a> to the result of calling 
 <a>report timing</a> given <var>response</var>, <var>global</var>, <var>initiatorType</var>, and 
 <var>taoPass</var>.
```

> +<var>global</var>, <var>initiatorType</var>, and the result of calling <a>TAO origin check</a> with
+<var>response</var> and the result of <a lt="ASCII serialization of an origin">serializing</a>
+<var>origin</var>.

```suggestion
<var>global</var>, <var>initiatorType</var>, the result of calling <a>TAO origin check</a> with
<var>response</var>, and the result of <a lt="ASCII serialization of an origin">serializing</a>
<var>origin</var>.
```
Right?

> +<p class=note>This algorithm is used by <cite>HTML</cite> to report resource timing for documents
+nested through <code>iframe</code> elements, as iframes report both to the <code>iframe</code>'s
+loaded document as navigation timing and to the containing document as resource timing. [[HTML]]

This read a little weird to me still. How about this:
```suggestion
<p class=note>This algorithm is used by <cite>HTML</cite> to report resource timing for documents
nested through <code>iframe</code> elements to their container document. (Nested documents also
report navigation timing to themselves.) [[HTML]]
```

> @@ -4347,7 +4372,7 @@ steps:
  <li><p>If <var>timingInfo</var> is null, then return.
 
  <li>
-  <p>If <var>response</var>'s <a for=response>timing allow passed flag</a> is not set, then:
+  <p>If <var>taoPass</var> is false, then:</p>

```suggestion
  <p>If <var>taoPass</var> is false, then:
```

> +<p>To perform a <dfn id=concept-tao-origin-check>TAO origin check</dfn> for a <a for=/>response</a>
+<var>response</var> and an <a for=/>ASCII string</a> <var>origin</var>, run these steps:

```suggestion
<p>To perform a <dfn>TAO origin check</dfn> for a <a for=/>response</a> <var>response</var> and an 
<a for=/>ASCII string</a> <var>origin</var>, run these steps:
```
This does not need to be exported, right?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1388#pullrequestreview-905690119
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1388/review/905690119@github.com>