Re: [whatwg/fetch] Process 103 Early Hints response (PR #1404)

@yoavweiss commented on this pull request.



>  
      <li>
-      <p>Any <a for=/>responses</a> whose <a for=response>status</a> is in the range 100 to 199,
-      inclusive, and is not 101, are to be ignored, except for the purposes of setting
-      <var>timingInfo</var>'s <a for="fetch timing info">final network-response start time</a> above.
+      <p>While true:
+      <ol>
+       <li><p>Wait until all the <a for=/>headers</a> are transmitted.

This changes the current meaning of "final network response start time". I think it might be worthwhile to discuss if it should mean the very first byte of the 103 status response or the very first byte of the non-103 one, but it shouldn't be the time we're done receiving all the headers.

> +
+       <li><p>If <var>responseStartTime</var> is null, set <var>responseStartTime</var> to
+       <a for=/>coarsened shared current time</a> given <var>fetchParams</var>'s
+       <a for="fetch params">cross-origin isolated capability</a>, immediately after the user
+       agent's HTTP parser receives the first byte of the response (e.g., frame header bytes for
+       HTTP/2 or response status line for HTTP/1.x).
+
+       <li><p>Let <var>status</var> be <a for=response>status</a> of <a for=/>response</a>.
+
+       <li><p>If <var>status</var> is in the range 100 to 199, inclusive:
+        <ol>
+         <li><p>If <var>status</var> is 101, <a for=iteration>break</a>.
+
+         <li><p>If <var>status</var> is 103, then:
+          <ol>
+           <li><p>If <var>fetchParams</var>'s <a for="fetch params">process early hints response</a>

@yutakahirano can you expand on what CORS breakage you had in mind? IIUC, the assert makes sure that Early Hints are not processes when they arrive on non-navigation responses (which makes sense).


-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1404#pullrequestreview-896134460
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1404/review/896134460@github.com>

Received on Tuesday, 1 March 2022 10:43:58 UTC