- From: Dan Robertson <notifications@github.com>
- Date: Mon, 20 Jun 2022 12:19:21 -0700
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 20 June 2022 19:19:33 UTC
@dlrobertson commented on this pull request. > So we call this "parse a single range header value" and it returns (start, null), (null, end), (start, end), or failure. And then adjust the caller to account for that. Yeah this makes sense, but after reading I wonder if it would also make sense to tackle the following comment and also change the parser to operate on a header list as part of this patch. From https://github.com/whatwg/fetch/issues/1070#issuecomment-1141315124 > Note that this parser needs to take a header list for consistency with "extract a MIME type" and friends. That also makes it clear that if you have multiple Range headers what value ends up being operated on and why that ends up failing (the comma). -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1454#pullrequestreview-1012679520 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fetch/pull/1454/review/1012679520@github.com>
Received on Monday, 20 June 2022 19:19:33 UTC