Re: [whatwg/dom] Specify default passive for document-level wheel/mousewheel/touchstart/touchmove events (PR #1087)

@annevk commented on this pull request.

Thank you for this PR! It's great to see this being tackled.

I found a couple nits and one more substantive issue.

> +   <li><p>|type| is one of "<code>touchstart</code>", "<code>touchmove</code>",
+   "<code>wheel</code>", or "<code>mousewheel</code>" [[TOUCH-EVENTS]] [[UIEVENTS]]
+
+   <li><p>|eventTarget| is a {{Window}}, or is a {{Node}} whose <a>node document</a> is
+   |eventTarget|, or is a {{Node}} whose <a>node document</a>'s <a>document element</a> is
+   |eventTarget|, or is a {{Node}} whose <a>node document</a>'s
+   <a lt="the body element">body element</a> is |eventTarget| [[!HTML]]

Missing dots?

> @@ -1098,6 +1100,26 @@ constructor steps are to do nothing.
 if this would be useful for your programs. For now, all author-created {{EventTarget}}s do not
 participate in a tree structure.</p>
 
+<p>The <dfn>default passive value</dfn>, given an event type |type| and an {{EventTarget}}
+|eventTarget|, is determined as follows:
+
+<ol>
+ <li>
+  <p>Return true if all of the following are true:
+
+  <ul>
+   <li><p>|type| is one of "<code>touchstart</code>", "<code>touchmove</code>",
+   "<code>wheel</code>", or "<code>mousewheel</code>" [[TOUCH-EVENTS]] [[UIEVENTS]]
+
+   <li><p>|eventTarget| is a {{Window}}, or is a {{Node}} whose <a>node document</a> is

Nits:
* Window object*
* `<a for=/>node</a>` instead of {{Node}} (multiple times).

> @@ -971,7 +971,7 @@ when something has occurred.
  <li><dfn for="event listener">type</dfn> (a string)
  <li><dfn for="event listener">callback</dfn> (null or an {{EventListener}} object)
  <li><dfn for="event listener">capture</dfn> (a boolean, initially false)
- <li><dfn for="event listener">passive</dfn> (a boolean, initially false)
+ <li><dfn for="event listener">passive</dfn> (null or a boolean)

I don't think the lack of a default works here. https://html.spec.whatwg.org/#activate-an-event-handler doesn't specify a value for it, for instance.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/1087#pullrequestreview-1010081908
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/1087/review/1010081908@github.com>