- From: Anne van Kesteren <notifications@github.com>
- Date: Tue, 14 Jun 2022 05:07:40 -0700
- To: whatwg/xhr <xhr@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 14 June 2022 12:07:52 UTC
@annevk commented on this pull request. This needs updating to align with the revised approach. > @@ -1017,16 +1013,9 @@ return <a>this</a>'s <a>cross-origin credentials</a>. <a for=response>aborted flag</a> is set, run the <a>request error steps</a> for <var>xhr</var>, <a event><code>abort</code></a>, and "{{AbortError!!exception}}" {{DOMException}}. - <li> - <p>Otherwise, if <var>xhr</var>'s <a for=XMLHttpRequest>response</a> is a - <a for=/>network error</a>, then: - - <ol> - <li><p><a for=/>Report timing</a> for <var>xhr</var>. - - <li><p>Run the <a>request error steps</a> for <var>xhr</var>, - <a event><code>error</code></a>, and "{{NetworkError!!exception}}" {{DOMException}}. - </ol> + <li><p>Otherwise, if <var>xhr</var>'s <a for=XMLHttpRequest>response</a> is a + <a for=/>network error</a>, thenr run the <a>request error steps</a> for <var>xhr</var>, ```suggestion <a for=/>network error</a>, then run the <a>request error steps</a> for <var>xhr</var>, ``` -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/xhr/pull/347#pullrequestreview-1005739478 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/xhr/pull/347/review/1005739478@github.com>
Received on Tuesday, 14 June 2022 12:07:52 UTC