Re: [w3c/gamepad] extensions: Add vibrationActuator and dual-rumble effect (PR #163)

@marcoscaceres commented on this pull request.



> +            |params|.
+            </li>
+            <li>Return {{GamepadHapticActuator/[[playingEffectPromise]]}}.
+            </li>
+          </ol>
+          <p>
+            When the effect completes, if it was not preempted, run these
+            steps:
+          </p>
+          <ol>
+            <li>[=Queue a global task=] on the [=relevant global object=] of
+            [=this=] using the [=gamepad task source=] to [=resolve=]
+            [=this=].{{GamepadHapticActuator/[[playingEffectPromise]]}} with
+            {{GamepadHapticsResult/"complete"}}.
+            </li>
+            <li>Set [=this=].{{GamepadHapticActuator/[[playingEffectPromise]]}}

Clearing [[playingEffectPromise]] should be done as part of the task. Otherwise, it reads like [[playingEffectPromise]] gets trashed before the task runs. 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/gamepad/pull/163#pullrequestreview-999192735
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/gamepad/pull/163/review/999192735@github.com>