- From: Marcos Cáceres <notifications@github.com>
- Date: Tue, 07 Jun 2022 23:32:54 -0700
- To: w3c/gamepad <gamepad@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 8 June 2022 06:33:06 UTC
@marcoscaceres commented on this pull request.
> + <li>If this actuator can [=play effects with type=]
+ |type:GamepadHapticEffectType|, return `true`.
+ </li>
+ <li>Otherwise, return `false`.
+ </li>
+ </ol>
+ </dd>
+ <dt>
+ <dfn>playEffect()</dfn> method
+ </dt>
+ <dd>
+ <p>
+ The {{GamepadHapticActuator/playEffect()}} method steps are:
+ </p>
+ <ol>
+ <li>If |params:GamepadEffectParameters| does not describe a [=valid
Can you help me understand this a bit.... wouldn't rejecting with a `TypeError` be better here? it seems a bit odd to resolve successfully for what is actually an error.
--
Reply to this email directly or view it on GitHub:
https://github.com/w3c/gamepad/pull/163#pullrequestreview-999183638
You are receiving this because you are subscribed to this thread.
Message ID: <w3c/gamepad/pull/163/review/999183638@github.com>
Received on Wednesday, 8 June 2022 06:33:06 UTC