Re: [w3c/IndexedDB] Support Storage Partitioning (PR #383)

@inexorabletash requested changes on this pull request.

#334 is probably pretty close now, I just hadn't spent any time on it. Just need to replace "pumpkin" with something. We definitely need #384 - hopefully I can get a reviewer to chime in soon.

> @@ -34,6 +34,7 @@ spec: html; urlPrefix: https://html.spec.whatwg.org/multipage/
     urlPrefix: dom.html
         type: interface
             text: Document; url: document
+        type:event; text:close

Rebasing on top of #384 will eliminate this. (If needed, it would go in the link-defaults pre anyway)

> @@ -65,6 +66,8 @@ spec: ecma262; urlPrefix: https://tc39.github.io/ecma262/
 spec: storage; urlPrefix: https://storage.spec.whatwg.org/
     type: dfn
         text: storage bucket; url: storage-bucket
+        text: storage key; url: storage-key
+        text: obtain a storage key; url: obtain-a-storage-key

This is exported, so shouldn't be necessary?

> @@ -2215,17 +2218,17 @@ The <dfn method for=IDBFactory>open(|name|, |version|)</dfn> method steps are:
 
 1. Let |environment| be [=/this=]'s [=/relevant settings object=].
 
-1. Let |origin| be |environment|'s [=environment settings object/origin=].
+1. Let |storageKey| be the result of running [=obtain a storage key=] given |environment|.

Reading the [definition](https://storage.spec.whatwg.org/#obtain-a-storage-key) "obtain a storage key" can return failure. That needs to be handled...

That takes care of opaque origins, too, so the subsequent step can be merged.

> @@ -6604,10 +6607,10 @@ of user tracking:
     User agents may require the user to authorize access to databases
     before a site can use the feature.
 
-: Origin-tracking of stored data
+: Storage Key tracking of stored data

This section was confusing before, and I don't think this improves the situation. Maybe rename to "Attribution of third-party storage" ?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/IndexedDB/pull/383#pullrequestreview-996900408
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/IndexedDB/pull/383/review/996900408@github.com>