Re: [whatwg/fetch] Add support for parsing a suffix byte range spec (PR #1454)

@dlrobertson commented on this pull request.

Thanks for the review!

> Note that I'll be out for at least another two weeks.

No problem! Enjoy your time off

> @@ -1077,14 +1081,14 @@ run these steps:
  <li><p>Return <var>values</var>.
 </ol>
 
-<p>To determine if a <a>byte sequence</a> <var>value</var> is a
-<dfn>simple range header value</dfn>, perform the following steps. They return a <a>boolean</a>.
+<p>To <dfn lt="parse a single range header value|single range header value">parse a single range header value</dfn>
+from a <a>byte sequence</a> <var>value</var>, run these steps:

> It returns failure or a https://infra.spec.whatwg.org/#tuples of two items each of which is null or a number.

I somehow missed tuples, but that was exactly what I was looking for.

> I'm not sure it's worth writing that out however.

Makes sense. I'll tinker with it and see if I can get something that isn't too wordy.

> @@ -1077,14 +1081,14 @@ run these steps:
  <li><p>Return <var>values</var>.
 </ol>
 
-<p>To determine if a <a>byte sequence</a> <var>value</var> is a
-<dfn>simple range header value</dfn>, perform the following steps. They return a <a>boolean</a>.
+<p>To <dfn lt="parse a single range header value|single range header value">parse a single range header value</dfn>

> We should also keep the ID simple-range-header-value working I think.

:+1: I think that is what I meant to do here, but failed at the implementation 😃 Will fix on the next update.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1454#pullrequestreview-1054381998

You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1454/review/1054381998@github.com>