- From: Yutaka Hirano <notifications@github.com>
- Date: Thu, 17 Feb 2022 21:55:02 -0800
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/fetch/pull/1404/review/886855339@github.com>
@yutakahirano commented on this pull request. Looks good overall. I want to have an assertion and note, as commented. > + + <li><p>If <var>responseStartTime</var> is null, set <var>responseStartTime</var> to + <a for=/>coarsened shared current time</a> given <var>fetchParams</var>'s + <a for="fetch params">cross-origin isolated capability</a>, immediately after the user + agent's HTTP parser receives the first byte of the response (e.g., frame header bytes for + HTTP/2 or response status line for HTTP/1.x). + + <li><p>Let <var>status</var> be <a for=response>status</a> of <a for=/>response</a>. + + <li><p>If <var>status</var> is in the range 100 to 199, inclusive: + <ol> + <li><p>If <var>status</var> is 101, <a for=iteration>break</a>. + + <li><p>If <var>status</var> is 103, then: + <ol> + <li><p>If <var>fetchParams</var>'s <a for="fetch params">process early hints response</a> I think we should have an assertion stating that when "process early hints response" is gven, the CORS mode is "navigate", and a note mentioning that this is not a CORS breakage with the assertion. I'm not sure which is the best place for them. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/pull/1404#pullrequestreview-886855339 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fetch/pull/1404/review/886855339@github.com>
Received on Friday, 18 February 2022 05:55:14 UTC