Re: [whatwg/fetch] Return a "controller" instance from fetch (#1329)

@annevk commented on this pull request.

Found a couple minor remaining issues. Also pinging @jakearchibald and @yutakahirano again for review.

> @@ -2104,6 +2130,16 @@ known as an <dfn export id=concept-aborted-network-error>aborted network error</
 <a for=response>header list</a> is always empty, and
 <a for=response>body</a> is always null.
 
+<p>To create the <dfn>appropriate network error</dfn> given <a for=/>fetch params</a>
+<var>fetchParams</var>:
+
+<ol>
+ <li><p>Assert: <var>fetchParams</var> is  <a for="fetch params">canceled</a>.</li>

```suggestion
 <li><p>Assert: <var>fetchParams</var> is <a for="fetch params">canceled</a>.</li>
```

>    </ol>
 
  <li><p>Let <var>pullAlgorithm</var> be an action that <a lt=resumed for=fetch>resumes</a> the
  ongoing fetch if it is <a lt=suspend for=fetch>suspended</a>.
 
- <li><p>Let <var>cancelAlgorithm</var> be an action that <a lt=terminated for=fetch>terminates</a>
- the ongoing fetch with the aborted flag set.
+ <li><p>Let <var>cancelAlgorithm</var> be an algorithm that
+ <a for="fetch controller">abort</a>s <var>fetchParams</var>'s <a for="fetch params">controller</a>.

```suggestion
 <a for="fetch controller">aborts</a> <var>fetchParams</var>'s <a for="fetch params">controller</a>.
```

> @@ -8074,6 +8085,11 @@ in a <a for=/>parallel queue</a> if <a for=fetch><i>useParallelQueue</i></a> is
  as arguments will be invoked. Hopefully most standards will not need this.
 </dl>
 
+<p>When invoked, the <a for=/>fetch</a> operation returns a <a for=/>fetch controller</a>.
+The controller is used for performing actions on a fetch operation that has already started,
+such as <a for="fetch controller" lt=abort>aborting</a> the operation by the user or page logic, or
+<a for="fetch controller" lt=abort>terminating</a> it due to a browser-internal circumstance.

No lt=abort here, right?

> @@ -2247,14 +2278,14 @@ functionality.
 
 <p>A <a for="fetch group">fetch record</a> has an associated
 <dfn export for="fetch record" id=concept-fetch-record-fetch>fetch</dfn> (a
-<a for=/>fetch</a> algorithm or null).
+<a for=/>fetch controller</a> or null).

Can you file an issue for this?

> @@ -4419,7 +4452,9 @@ these steps:
    given <var>fetchParams</var>'s <a for="fetch params">cross-origin isolated capability</a>.
 
    <li><p>Set <var>response</var> to the result of invoking <a for=/>handle fetch</a> for
-   <var>requestForServiceWorker</var>. [[!HTML]] [[!SW]]
+   <var>requestForServiceWorker</var>, with <var>fetchParams</var>'s
+   <a for="fetch params">controller</a> and <var>fetchParams</var>'s
+   <a for="fetch params">cross-origin isolated capability</a> and . [[!HTML]] [[!SW]]

This does not appear to be resolved?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1329#pullrequestreview-881626879
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1329/review/881626879@github.com>