- From: Peter Linss <notifications@github.com>
- Date: Thu, 10 Feb 2022 11:44:20 -0800
- To: w3ctag/design-reviews <design-reviews@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 10 February 2022 19:44:32 UTC
I'm curious why the choice of: ``` "user_preferences": { "color_scheme_dark": { "theme_color": "#000", "background_color": "#000" }, "color_scheme_light": { "theme_color": "#fff", "background_color": "#fff" } } ``` vs. something like: ``` "user_preferences": { "color_scheme": { "dark": { "theme_color": "#000", "background_color": "#000" }, "light": { "theme_color": "#fff", "background_color": "#fff" } } } ``` The latter seems more friendly to extensibility (e.g. easier to handle should more color schemes be added, i.e. no need to parse keys). Either way I'd like to see some examples of how other user preference media features would be specified and make sure that a common pattern emerges in the keys. -- Reply to this email directly or view it on GitHub: https://github.com/w3ctag/design-reviews/issues/696#issuecomment-1035411452 You are receiving this because you are subscribed to this thread. Message ID: <w3ctag/design-reviews/issues/696/1035411452@github.com>
Received on Thursday, 10 February 2022 19:44:32 UTC