- From: cynthia <notifications@github.com>
- Date: Tue, 08 Feb 2022 01:39:28 -0800
- To: w3ctag/design-reviews <design-reviews@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 8 February 2022 09:39:41 UTC
First of all, this looks pretty useful. API surface-wise, what happens when one tries to create a crop target on a element that is not attached to a document, hence not visible? (I assume it can be rendered and therefore can be captured, but seems like a bug or an interesting side-effect feature?) I see benefits from having the element being the region boundary, but also a bit unconventional. Initially we thought this was replicating what native does and provides a bounding box to be streamed, but that does not seem to be the case here. This feels like a user expectation that should be fulfilled. We weren't able to figure out the user flow of how the preview is presented the user in the example code. Is it triggered when the crop target promise is being returned? (Presumable rejecting if the user dismisses the preview as "please don't"?) -- Reply to this email directly or view it on GitHub: https://github.com/w3ctag/design-reviews/issues/710#issuecomment-1032403736 You are receiving this because you are subscribed to this thread. Message ID: <w3ctag/design-reviews/issues/710/1032403736@github.com>
Received on Tuesday, 8 February 2022 09:39:41 UTC