Re: [whatwg/dom] Add new mutation observer init options elementByAttributeFilter and elementFilter (#885)

@smaug---- commented on this pull request.



> +     <li><p>Let <var>nodeAttributesList</var> be the set of <a for=Attr>local name</a>s of <var>node</var>'s
+     <a>attribute</a>s.
+
+     <li>
+      <p>If none of the following are true
+
+      <ul class=brief>
+       <li><var>options</var>'s {{MutationObserverInit/elementFilter}} is present, and the
+       <a>node</a>'s <var>localName</var> is in {{MutationObserverInit/elementFilter}}
+
+       <li><var>options</var>'s {{MutationObserverInit/elementByAttributeFilter}} is present, and
+       <var>options</var>'s {{MutationObserverInit/elementByAttributeFilter}} contains any of the
+       attribute names in <var>nodeAttributesList</var>
+      </ul>
+
+      <p>then <a for=list>append</a> <var>node</var> to <var>filterRemovedNodes</var>.

I must be confused here.
Don't we want something like
if elementFilter is present, and elementByAttributeFilter is not present and localName is in elementfilter, or if 
elementByAttributeFilter is present and elementFilter is not present and elementByAttributeFilter contains any of the attribute names in nodeAttribute list ...  or combination of those two

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/885#pullrequestreview-1216547039
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/dom/pull/885/review/1216547039@github.com>