Re: [whatwg/fetch] Editorial: Amend body reading to use no-promise version (PR #1569)

@domenic commented on this pull request.



> @@ -1465,32 +1465,19 @@ null), run these steps. <var>processBody</var> must be an algorithm accepting a
  <li><p>If <var>taskDestination</var> is null, then set <var>taskDestination</var> to the result of
  <a>starting a new parallel queue</a>.
 
- <li><p>Let <var>promise</var> be the result of <a>fully reading body as promise</a> given
- <var>body</var>.
-
  <li><p>Let <var>fulfilledSteps</var> given a <a>byte sequence</a> <var>bytes</var> be to

Should be renamed to successSteps/errorSteps since there is no more promise fulfillment/rejection going on.

> @@ -6958,8 +6945,25 @@ the associated steps:
  <li><p>Let <var>promise</var> be <a>a promise resolved with</a> an empty
  <a for=/>byte sequence</a>.
 
- <li><p>If <var>object</var>'s <a for=Body>body</a> is non-null, then set <var>promise</var> to the
- result of <a>fully reading body as promise</a> given <var>object</var>'s <a for=Body>body</a>.
+ <li>
+  <p>If <var>object</var>'s <a for=Body>body</a> is non-null, then:
+
+  <ol>
+   <li><p>Set <var>promise</var> to <a>a new promise</a>.
+
+   <li><p>Let <var>fulfilledSteps</var> given a <a>byte sequence</a> <var>bytes</var> be to

Same here. (Although I guess resolveSteps/rejectSteps would be OK too.)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1569#pullrequestreview-1215005449
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1569/review/1215005449@github.com>