- From: Noam Rosenthal <notifications@github.com>
- Date: Mon, 12 Dec 2022 22:16:31 -0800
- To: whatwg/streams <streams@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Tuesday, 13 December 2022 06:16:51 UTC
@noamr commented on this pull request. > 1. Let |promise| be [=a new promise=]. - 1. Let |bytes| be an empty [=byte sequence=]. - 1. [=Read-loop=] given |reader|, |bytes|, and |promise|. - 1. Return |promise|. + 1. Let |success steps| given a [=byte sequence=] |data| be to [=resolve=] |promise| with |data|. + 1. Let |failure steps| given a JavaScript value |error| be to [=reject=] |promise| with |error|. + 1. [=Consume all bytes=] from |reader| given |success steps| and |failure steps|. sounds good, once this is reviewed I'll post a Fetch patch and issues to the other specs. -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/streams/pull/1250#discussion_r1046698203 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/streams/pull/1250/review/1214769432@github.com>
Received on Tuesday, 13 December 2022 06:16:51 UTC