- From: Marcos Cáceres <notifications@github.com>
- Date: Sun, 11 Dec 2022 17:16:29 -0800
- To: w3c/gamepad <gamepad@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Monday, 12 December 2022 01:16:41 UTC
@marcoscaceres approved this pull request. This is an improvement, but I don't think this is exactly right... I think we should use #136 here.. I think what we actually want is: * The model says there is a *conceptual gamepads* 🎮🎮🎮 representing real things. * When .getGamepads() is called, we go to the model and "snapshot" each conceptual gamepad (i.e., make the lists, copy stuff from the conceptual ones). * return the result. Right now, this reads like we are recycling what is normally returned by `.getGamepads()`. I'm approving, but let's move to using the model. -- Reply to this email directly or view it on GitHub: https://github.com/w3c/gamepad/pull/172#pullrequestreview-1212798721 You are receiving this because you are subscribed to this thread. Message ID: <w3c/gamepad/pull/172/review/1212798721@github.com>
Received on Monday, 12 December 2022 01:16:41 UTC