- From: Dan Robertson <notifications@github.com>
- Date: Sat, 10 Dec 2022 18:35:49 -0800
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/fetch/issues/1566@github.com>
Some algorithms have unused variables: - Two algorithms have a `controller` variable, but use `this` in the steps. I think `controller` should be used instead. - [report timing](https://fetch.spec.whatwg.org/#finalize-and-report-timing) - [extract full timing info ](https://fetch.spec.whatwg.org/#extract-full-timing-info) - The optional `extract-value flag` for [collect an HTTP quoted string](https://fetch.spec.whatwg.org/#collect-an-http-quoted-string) is never used. Some reading of prior commits seems to indicate this was added to make the algorithm suitable for header list `getting, decoding, and splitting`. Using https://github.com/whatwg/fetch/pull/1565: ``` ❯ make remote % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 353k 0 459 100 353k 49 38777 0:00:09 0:00:09 --:--:-- 124 Error running preprocessor, returned code: 2. WARNING: The following <var>s were only used once in the document: 'controller', in algorithm 'report timing' for fetch controller 'controller', in algorithm 'extract full timing info given a fetch controller controller:' for fetch controller 'extract-value flag' If these are not typos, please add an ignore='' attribute to the <var>. ✘ Did not generate, due to fatal errors make: *** [remote] Error 22 ``` -- Reply to this email directly or view it on GitHub: https://github.com/whatwg/fetch/issues/1566 You are receiving this because you are subscribed to this thread. Message ID: <whatwg/fetch/issues/1566@github.com>
Received on Sunday, 11 December 2022 02:36:03 UTC