Re: [w3c/permissions] Editorial: fix PermissionDescriptor name check in query() (PR #404)

@annevk approved this pull request.



> @@ -801,8 +801,14 @@ <h4 id="query-method">
                 </li>
               </ol>
             </li>
-            <li>If |permissionDesc|'s {{PermissionDescriptor/name}} member is not supported, return
-            [=a promise rejected with=] a {{TypeError}}.
+            <li>Let |rootDesc| be the object |permissionDesc| refers to, <a>converted to an IDL
+            value</a> of type {{PermissionDescriptor}}.
+            </li>
+            <li>If the conversion [=exception/throws=] an [=exception=], return <a>a promise
+            rejected with</a> that exception.
+            </li>
+            <li>If |rootDesc|'s {{PermissionDescriptor/name}} member is not supported, return [=a

Nit (although I guess this might apply throughout in which case it's probably best done separately):
```suggestion
            <li>If |rootDesc|["{{PermissionDescriptor/name}}"] is not supported, return [=a
```


-- 
Reply to this email directly or view it on GitHub:
https://github.com/w3c/permissions/pull/404#pullrequestreview-1210305051
You are receiving this because you are subscribed to this thread.

Message ID: <w3c/permissions/pull/404/review/1210305051@github.com>