Re: [whatwg/fetch] Add support for blob range requests (PR #1520)

@annevk commented on this pull request.

Modulo a couple tiny nits this looks good.

Are Chromium and WebKit passing all the tests or should there be bugs on them as well?

> @@ -4648,21 +4648,107 @@ steps:
       <p class=note>The `<code>GET</code>` <a for=/>method</a> restriction serves no useful purpose
       other than being interoperable.
 
-     <li><p>Let <var>bodyWithType</var> be the result of <a for=BodyInit>safely extracting</a>
-     <var>blobURLEntry</var>'s <a for="blob URL entry">object</a>.
+     <li><p>Set <var>response</var> to a new <a for=/>response</a>.

```suggestion
     <li><p>Let <var>response</var> be a new <a for=/>response</a>.
```

> +       <li><p>If <var>rangeValue</var>[0] is non-null, then
+       <a lt="serialize an integer">serialize</a> and
+       <a>isomorphic encode</a> <var>rangeValue</var>[0], and append the result to
+       <var>contentRange</var>.

```suggestion
       <li><p>If <var>rangeValue</var>[0] is non-null, then
       <a lt="serialize an integer">serialize</a> and <a>isomorphic encode</a>
       <var>rangeValue</var>[0], and append the result to <var>contentRange</var>.
```

> +       <li><p>If <var>sliceEndRange</var> is non-null, then
+       <a lt="serialize an integer">serialize</a> and
+       <a>isomorphic encode</a> <var>sliceEndRange</var>, and append the result to
+       <var>contentRange</var>.

```suggestion
       <li><p>If <var>sliceEndRange</var> is non-null, then
       <a lt="serialize an integer">serialize</a> and <a>isomorphic encode</a>
       <var>sliceEndRange</var>, and append the result to <var>contentRange</var>.
```

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1520#pullrequestreview-1209915882
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1520/review/1209915882@github.com>