Re: [whatwg/url] Editorial: adopt Infra for URLSearchParams (PR #717)

@domenic approved this pull request.

LGTM modulo the variable naming discussion

> @@ -3345,20 +3345,19 @@ console.log(url.searchParams.get('b')); // "~"</code></pre>
 
 <ol>
  <li>
-  <p>If <var>init</var> is a <a>sequence</a>, then <a for=list>for each</a> <var>pair</var> in
+  <p>If <var>init</var> is a <a>sequence</a>, then <a for=list>for each</a> <var>tuple</var> of

Honestly I think _subSequence_ or _innerSequence_ would be a better name. It's confusing to use the variable name _tuple_ for something that's actually an Infra list/IDL sequence.

For example, at first I wrote a comment below "Why not just append _tuple_ directly, instead of appending (_tuple_[0], _tuple_[1])?" But now I see that would be a type error. I was misled by the variable name.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/url/pull/717#pullrequestreview-1203858221
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/url/pull/717/review/1203858221@github.com>