- From: Anne van Kesteren <notifications@github.com>
- Date: Fri, 02 Dec 2022 08:02:21 -0800
- To: whatwg/fetch <fetch@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
- Message-ID: <whatwg/fetch/pull/1523/review/1202713132@github.com>
@annevk approved this pull request.
Thanks! This looks good to me. I have a couple final nits I can take care of when merging.
Where is the corresponding HTML PR again?
Could you post a suggested commit message in a new comment that includes all the relevant details and pointers to issues/documents/PRs? You can use https://github.com/whatwg/meta/blob/main/COMMITTING.md for guidance.
I think this can be merged Wed or Thu next week assuming it all checks out.
> @@ -1734,8 +1734,11 @@ not always relevant and might require different behavior.
<hr>
<p>A <a for=/>request</a> has an associated
-<dfn export for=request id=concept-request-priority>priority</dfn> (null or a
Note to self: preserve this ID. (No need to do anything. I will take care of this before merging.)
>
- <p class=note>The user-agent-defined object could encompass stream weight and dependency for
- HTTP/2, and equivalent information used to prioritize dispatch and processing of HTTP/1 fetches.
+ <p class=note>The <a>implementation-defined</a> object could encompass stream weight and
+ dependency for HTTP/2, priorities used in <cite>Extensible Prioritization Scheme for HTTP</cite>
+ for transports where it applies (including HTTP/3), and equivalent information used to prioritize
```suggestion
for transports where it applies (including HTTP/3), and equivalent information used to prioritize
```
> + <ol>
+ <li><p>If <var>request</var>'s <a for=request>internal priority</a> is not null, update
+ <var>request</var>'s <a for=request>internal priority</a> appropriately.
+
+ <li><p>Otherwise, set <var>request</var>'s <a for=request>priority</a> to the value of
+ <var>init</var>["{{RequestInit/priority}}"].
```suggestion
<ol>
<li><p>If <var>request</var>'s <a for=request>internal priority</a> is not null, then update
<var>request</var>'s <a for=request>internal priority</a> appropriately.
<li><p>Otherwise, set <var>request</var>'s <a for=request>priority</a> to
<var>init</var>["{{RequestInit/priority}}"].
```
```
--
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1523#pullrequestreview-1202713132
You are receiving this because you are subscribed to this thread.
Message ID: <whatwg/fetch/pull/1523/review/1202713132@github.com>
Received on Friday, 2 December 2022 16:02:33 UTC