- From: Jeffrey Yasskin <notifications@github.com>
- Date: Thu, 01 Dec 2022 09:41:07 -0800
- To: w3c/permissions <permissions@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Thursday, 1 December 2022 17:41:20 UTC
@jyasskin commented on this pull request. > + "export">request permission to use</dfn> a |descriptor:PermissionDescriptor|, with + optionally a |promise:Promise|: We need to make call sites easy to read, and I don't think "request permission to use |descriptor| with |promise|" explains to readers what the promise is going to mean. Readers shouldn't need to click through in order to read the call site, which means the call site needs to mention [=transient activation=]. I think something like ```suggestion "export">request permission to use</dfn> a |descriptor:PermissionDescriptor|, optionally with [=transient activation=] consumed through a |promise:Promise|: ``` would be somewhat better, although "consumed through" is still obscure, and you might come up with better ideas. -- Reply to this email directly or view it on GitHub: https://github.com/w3c/permissions/pull/401#pullrequestreview-1201424038 You are receiving this because you are subscribed to this thread. Message ID: <w3c/permissions/pull/401/review/1201424038@github.com>
Received on Thursday, 1 December 2022 17:41:20 UTC