Re: [whatwg/storage] Editorial: Add a diagram for storage model (PR #152)

@annevk commented on this pull request.



> +      <path fill="none" stroke="gray" d="M3 9v18m6-9q18-18 36 0-18 18-36 0"/>
+    </marker>
+  </defs>
+  <defs>
+    <marker id="c" markerHeight="36" markerWidth="57" orient="auto" refX="39" refY="18">
+      <circle cx="9" cy="18" r="6" fill="#fff" stroke="gray"/>
+      <path fill="none" stroke="gray" d="M21 18q18-18 36 0-18 18-36 0"/>
+    </marker>
+  </defs>
+  <path fill="none" stroke="gray" marker-end="url(#a)" marker-start="url(#b)" d="M73.762 95v8.333c0 8.334 0 25 10.862 41.667 10.863 16.667 32.588 33.333 43.45 41.667L138.937 195" class="er relationshipLine"/>
+  <path fill="none" stroke="gray" marker-end="url(#a)" marker-start="url(#b)" d="M301.875 95v8.333c0 8.334 0 25-10.863 41.667-10.862 16.667-32.587 33.333-43.45 41.667L236.7 195" class="er relationshipLine"/>
+  <path fill="none" stroke="gray" marker-end="url(#c)" marker-start="url(#b)" d="M187.818 270v100" class="er relationshipLine"/>
+  <path fill="none" stroke="gray" marker-end="url(#a)" marker-start="url(#b)" d="M187.818 445v100" class="er relationshipLine"/>
+  <path fill="none" stroke="gray" marker-end="url(#d)" marker-start="url(#b)" d="M187.818 620v100" class="er relationshipLine"/>
+  <path fill="#f0fff0" fill-opacity="100%" stroke="gray" d="M20 20h107.523v75H20z" class="er entityBox"/>
+  <text class="er entityLabel" dominant-baseline="middle" style="font-family:&quot;trebuchet ms&quot;,verdana,arial,sans-serif;font-size:16px" text-anchor="middle" transform="translate(73.762 57.5)">User agent</text>

I just looked at this and SVGOMG has a "Style to attributes" option that indeed reduces the file size further. Not sure how to use that from CLI however.

The other things I see are the redundant `aria-*` attribute and a bunch of useless `class` attributes.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/storage/pull/152#discussion_r1037227169
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/storage/pull/152/review/1201168709@github.com>

Received on Thursday, 1 December 2022 15:09:29 UTC