Re: [whatwg/fetch] Add abort reason to abort fetch (PR #1343)

@noamr commented on this pull request.



> @@ -7797,15 +7815,24 @@ method steps are:
    <li><p><a for=/>Resolve</a> <var>p</var> with <var>responseObject</var>.
   </ol>
 
+ <li><p>Let <var>error</var> be <var>requestObject</var>'s <a for=Request>signal</a>'s
+ <a for=AbortSignal>abort reason</a> if it not undefined. Otherwise, let <var>error</var> be an
+ "{{AbortError}}" {{DOMException}}.
+
+ <li><p>Let <var>serializedError</var> be the result of calling [$StructuredSerialize$]

I don't believe this is the right place to serialize. It should be done in `abort fetch`, not when the fetch is started.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1343#pullrequestreview-1072433920
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1343/review/1072433920@github.com>