- From: Nolan Lawson <notifications@github.com>
- Date: Wed, 10 Aug 2022 15:00:42 -0700
- To: WICG/webcomponents <webcomponents@noreply.github.com>
- Cc: Subscribed <subscribed@noreply.github.com>
Received on Wednesday, 10 August 2022 22:00:54 UTC
@nolanlawson commented on this pull request. > @@ -60,6 +60,8 @@ registry.define('other-element', OtherElement); Definitions in this registry do not apply to the main document, and vice-versa. The registry must contain definitions for all elements used. +Note that, in the above example, `<other-element>` is defined in the scoped registry, not `<my-element>`. The registry applies to definitions _within_ the shadow root, not the element that the shadow root is attached to. I tried to tweak the language a bit. Maybe I'm only muddying things further, but the existence of `<my-element>` really confused me when I first read this, so I'm trying to call that out. Arguably this example could just attach the shadow root to a div (or something), but that might be even more confusing since it isn't a common usage of shadow DOM. -- Reply to this email directly or view it on GitHub: https://github.com/WICG/webcomponents/pull/965#discussion_r942941134 You are receiving this because you are subscribed to this thread. Message ID: <WICG/webcomponents/pull/965/review/1068980919@github.com>
Received on Wednesday, 10 August 2022 22:00:54 UTC