Re: [whatwg/fetch] Separate DNS timing info from proxy resolution (PR #1429)

@annevk commented on this pull request.

Thanks for catching this!

>     <li>
+    <li><p>Let <var>timingInfo</var> be a new <a for=/>connection timing info</a> whose
+    <a for="connection timing info">domain lookup start time</a> is
+    <var>domainLookupStartTime</var>.
+

The first `<li>` needs to move down and the other needs to be indented one less.

> @@ -2619,6 +2620,9 @@ boolean <var>http3Only</var>, run these steps:
 <a for=connection>timing info</a> and observe these requirements:
 
 <ul>
+ <li><p><var>timingInfo</var>'s <a for="connection timing info">domain lookup end time</a> should be
+ the time after resolving the IP address of the server or proxy. [[SVCB]]

This is already required by the algorithm above, no? I don't think we should require it twice.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fetch/pull/1429#pullrequestreview-953295782
You are receiving this because you are subscribed to this thread.

Message ID: <whatwg/fetch/pull/1429/review/953295782@github.com>

Received on Tuesday, 26 April 2022 12:32:28 UTC